[GH-ISSUE #82] Wind could be a single signed byte (-128..127) #252

New Issue

2026-05-20T22:35:00+02:00

Pecus commented

2026-05-20 22:35:00 +02:00

Originally created by @pkali on GitHub (May 28, 2022).
Original GitHub issue: https://github.com/pkali/scorch_src/issues/82

Now it is unsigned byte and wind direction is saved in the WindOrientation flag. Switching to a signed byte would make it possible to remove redundant code.

Originally created by @pkali on GitHub (May 28, 2022). Original GitHub issue: https://github.com/pkali/scorch_src/issues/82 Now it is unsigned byte and wind direction is saved in the `WindOrientation` flag. Switching to a signed byte would make it possible to remove redundant code.

Pecus added the optimization label 2026-05-20 22:35:00 +02:00

Pecus closed this issue

2026-05-20 22:35:00 +02:00

Pecus commented

2026-05-20 22:35:00 +02:00

@pkali commented on GitHub (Jun 4, 2022):

oh boy, I thought it would be a nice walk in the park at the beginning of the weekend, but it turned out to be more difficult than expected.
Good point is that the whole Flight routine got significantly simpler now!
Not only Wind is now signed, but also vx is signed, too. Unfortunately, they are 4 bytes each, not really a speedup here :)

@pkali commented on GitHub (Jun 4, 2022): oh boy, I thought it would be a nice walk in the park at the beginning of the weekend, but it turned out to be more difficult than expected. Good point is that the whole Flight routine got significantly simpler now! Not only Wind is now signed, but also `vx` is signed, too. Unfortunately, they are 4 bytes each, not really a speedup here :)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/scorch_src#252